Votekick player count fix and "ghost player" fix - #20
Open
Roman243243 wants to merge 3 commits into
Open
Roman243243 wants to merge 3 commits into
Roman243243 wants to merge 3 commits into
Conversation
"Ghost player" appears when player leaves while loading map with datapatch For some reason it doesnt trigger PlayerLeave event
Owner
|
??? Why using a timer ? That's not appropriate. This is probably a mindustry but because MoreCommands is properly removing players |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before plugin was counting all players from all teams, which made votekicking impossible in some cases (example: 3 vs 3)
"Ghost player" is when player left, but plugin thinks he is still on server. It happens when map has datapatch and player leaves while loading map