Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge unless you want to switch the EdDSA escrow key off. This PR exists so that turning it off is one click instead of a scramble.
Renames
eddsa/d/k.pem→eddsa/d/k_disabled.pemin a single commit. The key content is unchanged and stays in the repo; only the filename changes, which is what decides whether the app finds it. This is the same disarm convention already used for the ECDSA key (q/k_disabled.pemon the per-env branches).What merging this does. The URL the mobile app reads returns 404 again:
The app treats that as "the recovery key has not been published yet" — a normal, non-error state. EdDSA server recovery simply stops being offered on dev / dev2 / qastaging. Nothing crashes, no app release is needed, and normal app usage is unaffected either way.
When you would merge it. If the published key causes unwanted EdDSA recovery prompts on dev / dev2 / qastaging (those three environments have the URL configured but are not covered by the in-app QA fixture gate, so they act on it), or if the key needs to be withdrawn for any other reason.
To re-arm afterwards: rename back to
k.pem.Related: ZW-16371.