🐛 Unbreak CI on the current stable Rust

[manupawickramasinghe]

Merge order: #32 (unbreaks currently-red CI) → #28 → #29 → #30 → #31. Each is independently reviewable; the order just keeps the checks readable.

Merge this one first. master's CI is red on Windows and macOS right now, which makes every other PR's checks hard to read.

What broke

Nothing in this project. Rust 1.98 added clippy::chunks_exact_to_as_chunks, and CI runs dtolnay/rust-toolchain@stable with -D warnings — so a lint introduced by a toolchain release fails the build with nothing having been pushed.

error: using `chunks_exact` with a constant chunk size
   --> src\source\firmware.rs:190:17
    | help: consider using `as_chunks` instead: `as_chunks::<4>().0.iter()`
    = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`

Two sites, one per platform — which is exactly why the Linux leg stayed green, since neither compiles there:

Site	Platform
src/source/firmware.rs:190 — buf.chunks_exact(4)	Windows (ACPI table enumeration)
src/source/macos/dvfs.rs:80 — bytes.chunks_exact(8)	macOS (pmgr voltage states)

The fix

Both use as_chunks::<N>(), the replacement the lint itself suggests. Semantics are identical — the trailing partial chunk is dropped either way. The firmware site gets slightly simpler on the way, since as_chunks yields &[u8; 4] and the signature converts without re-indexing:

buf.as_chunks::<4>().0.iter().map(|c| u32::from_ne_bytes(*c))

The MSRV floor does not move. slice::as_chunks has been stable since Rust 1.88; this crate declares rust-version = "1.95".

Verification

• cargo clippy --all-targets -- -D warnings -D clippy::await_holding_lock — exit 0 on Windows.
• Full test suite: 83 passed, 0 failed.
• The macOS site cannot be compiled on this machine, so its expression was type-checked standalone and asserted to drop a trailing partial pair exactly as chunks_exact did (2 whole pairs from 19 bytes, remainder dropped). The macOS leg of CI is what actually proves it.

One thing worth recording: local clippy could not reproduce this at all. This machine is on rustc 1.97.1 and the lint arrived in 1.98 — so the failure was only visible from the CI logs, not from a local run.

Worth considering separately

This will recur. -D warnings against a floating stable toolchain means any future clippy release can turn CI red without a commit. Options are pinning the toolchain, or splitting the lint gate into a non-blocking job — a policy call rather than something to decide inside a fix.

🤖 Generated with Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.