fix: deserialize namespaced TaxNumberType and RECEIPT linked transactions - #243
Open
ryanduguid wants to merge 1 commit into
Open
fix: deserialize namespaced TaxNumberType and RECEIPT linked transactions#243ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
…nums Generated setters reject TaxNumberType TAXNUMBERTYPE/SSN (XeroAPI#203, XeroAPI#205) and LinkedTransaction SourceTransactionTypeCode RECEIPT (XeroAPI#206). Deserialization now retries namespaced values as their suffix, then preserves the raw API value on the private field so one unknown enum cannot drop a valid payload. Valid members (EIN, ACCPAY, SPEND) still go through the generated setters.
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #203, #205, #206.
The Accounting API returns enum members this generated SDK does not list:
Those values hit a closed `allowed_values` setter and raise `ValueError`, so an otherwise valid GET payload cannot be deserialized. Callers have been monkey-patching the setter.
This change lives in the non-generated deserializer:
Companion spec patch: Xero-OpenAPI (RECEIPT on `SourceTransactionTypeCode`, note on namespaced tax number types). Regenerating models alone would still leave in-flight SDK users broken until the next release; this unblocks them now.
Test plan