fix(senshi): restore Vidcloud playback - #121
Merged
Merged
Conversation
Owner
|
Big one, thanks for this. Senshi playback was broken and you came through with the full port, the EM3U8v1 decryption and proxy work is genuinely impressive. Reviewed the whole thing, everything checks out. Merging. |
Contributor
Author
|
Thanks for reviewing, It's mainly done by AI, but my trick was to give it a good context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the current, working Tachiyomi Senshi extension flow into Curd.
The port preserves Curd’s MAL-based provider IDs while adopting the extension’s current search schema, headers, source resolution, dynamic playlist-key extraction, and fallback key.
Evidence
Before: Senshi returned an SPA stream URL that mpv could not play. Direct media segments also returned
403without the requiredOriginheader.After: The live integration test completes search → episodes → embeds → Vidcloud source → encrypted master → encrypted variant → media segment.
Full suite:
go test ./... -count=1Race check:
CGO_ENABLED=1 go test -race ./internal/providers/senshi -count=1Live Senshi flow:
CURD_LIVE_SENSHI=1 go test ./internal/providers/senshi -run TestLiveSenshiPlaybackResolution -v -count=1Merge Danger
Door: Two-way
The implementation is isolated to the Senshi provider and can be reverted without data migration or configuration changes.
Blast Radius: Provider-local
The main risk is future Senshi or Vidcloud protocol changes, particularly playlist-key rotation. Dynamic key extraction and a verified fallback key reduce that risk.
Screenshot