Repository navigation
docs, sdks: land the fan-out fix-up text no PR carries - #376
Merged
Merged
Conversation
Each fan-out branch wrote its text without the other round in place. The #367 preview fixed that in e025a9f; these are the parts of it that no landing PR brings to main: - antd-csharp: the unknown-example message lists 1-9, 'pointers' and 'manifests'; README shows `dotnet run -- 9`. - antd-swift: NotSupportedError covers the pointer and manifest methods (doc comment and README error table). - antd-js README: 8 runnable scripts; 09-manifests.ts listed before the retry helper. Also from the #348 review: 2^53 itself parses exactly, so the JS size comment now says what goes wrong past 2^53 - 1 (2^53 + 1 reads as 2^53). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nic-dorman
added a commit
that referenced
this pull request
Oct 19, 2026
Main now has the whole pointer and manifest stack plus #376, so this PR's diff against main is just its own wording. Clean merge, no conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pointer (V2-1568) and manifest (V2-1580) fan-outs each wrote their SDK text without the other round in place. The #367 preview fixed that in e025a9f. Most of those fixes reached main through the per-PR merges, but no landing PR carries these five files:
pointersandmanifests; the README showsdotnet run -- 9.NotSupportedErrorcovers the pointer and manifest methods (doc comment and the README error table).09-manifests.tsis listed before the retry helper.Also from the #348 review: 2^53 itself parses exactly, so the JS manifest size comment now says what actually goes wrong past 2^53 - 1 (2^53 + 1 reads as 2^53). Comment only; the check is unchanged.
Text and comments only, no behaviour change. With this in, those five files match the #367 preview (bc339ab) exactly.
Landing order: it merges cleanly before or after #361 and the stacked follow-ups #369, #370, #371 and #375. Landing it before them means their diffs against main show only their own changes once they're retargeted.
🤖 Generated with Claude Code