Isolate global log report-hint test from ambient WAL changes - #5272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global-log timestamp/stack-trace test injected its failure before query dispatch but still resolved the ambient database while persisting last-failure provenance. A changing WAL can therefore suppress the report hint even when lifecycle logging succeeds.
The test now pins a private, absent
--db, scopes configuration discovery and text-log provenance, and restores its environment, culture, and snapshot hook. One shared theory covers stable and continuously changing ambient WALs, verifies the three-attemptquery_only_wal_changedboundary, and retains the report-hint, UTC, and stack-trace assertions. Production behavior is unchanged. This establishes a deterministic interference mechanism, not proof of the historical run's cause or process-state leakage.Validation:
GlobalToolLogTestscases passed on each framework.dotnet format CodeIndex.sln --verify-no-changes --no-restore, and bilingual fragment validation passed.origin/main..HEAD: No blocking/actionable issues found.Documentation: updated the English and Japanese sections of
TESTING_GUIDE.md; addedchangelog.d/unreleased/5264.internal.md. No production documentation or agent instruction changes are needed.Fixes #5264