Skip to content

Isolate global log report-hint test from ambient WAL changes - #5272

Merged
Widthdom merged 2 commits into
mainfrom
fix-issue5264
Sep 6, 2026
Merged

Isolate global log report-hint test from ambient WAL changes#5272
Widthdom merged 2 commits into
mainfrom
fix-issue5264

Conversation

@Widthdom

@Widthdom Widthdom commented Sep 5, 2026

Copy link
Copy Markdown
Owner

The global-log timestamp/stack-trace test injected its failure before query dispatch but still resolved the ambient database while persisting last-failure provenance. A changing WAL can therefore suppress the report hint even when lifecycle logging succeeds.

The test now pins a private, absent --db, scopes configuration discovery and text-log provenance, and restores its environment, culture, and snapshot hook. One shared theory covers stable and continuously changing ambient WALs, verifies the three-attempt query_only_wal_changed boundary, and retains the report-hint, UTC, and stack-trace assertions. Production behavior is unchanged. This establishes a deterministic interference mechanism, not proof of the historical run's cause or process-state leakage.

Validation:

  • Before the DB pin, the changing-WAL case reproduced the exact missing-report-hint assertion on both net8.0 and net9.0; the stable control passed on both.
  • After the fix, all 36 GlobalToolLogTests cases passed on each framework.
  • Full suites, with no concurrent dogfood index writes: net8.0 passed 12,263 / skipped 9; net9.0 passed 11,774 / skipped 435; zero failures on either framework.
  • After integrating the latest main and preserving both testing-guide entries at the conflict, the combined logging and search-alternative suites passed all 46 cases on each framework. The full runs above preceded this upstream test-only change.
  • Solution build, dotnet format CodeIndex.sln --verify-no-changes --no-restore, and bilingual fragment validation passed.
  • Codex adversarial review of origin/main..HEAD: No blocking/actionable issues found.

Documentation: updated the English and Japanese sections of TESTING_GUIDE.md; added changelog.d/unreleased/5264.internal.md. No production documentation or agent instruction changes are needed.

Fixes #5264

@Widthdom
Widthdom merged commit 8cc3683 into main Sep 6, 2026
11 checks passed
@Widthdom
Widthdom deleted the fix-issue5264 branch September 6, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate full-suite-only failure in global log report-hint test

1 participant