Repository navigation
ci(release): stop committing release artifacts back to protected main - #2
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughThe release configuration removes the changelog and Git plugins and retains the npm plugin. The package removes the corresponding development dependencies. ChangesRelease plugin cleanup
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk is identified. The release change is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
Full details: Changelog EntryExplanation The PR changes release configuration in
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Why
This repo's release job runs semantic-release with
@semantic-release/git, which pushes achore(release)commit back tomain.mainis branch-protected (PR + 1 approval), so that push is rejected:It fails in the prepare step, before npm publish, so nothing gets published. The most recent release run that got that far was run 37086082219: it computed 1.0.1 and then hit GH006. There's no
v1.0.1tag.What
Same fix as WYRE-AI/node-datto-saas-protection#59, matching
node-threatlocker's config, which releases fine under branch protection:.releaserc.jsondrops@semantic-release/changelogand@semantic-release/git. Remaining plugins:commit-analyzer,release-notes-generator,npm,github.branchesis unchanged (main).@semantic-release/changelogand@semantic-release/gitdevDependencies and refreshespackage-lock.json(npm 10).Effects
package.jsononmainkeeps showing1.0.0.@semantic-release/npmsets the version in the published tarball at publish time.@semantic-release/github.CHANGELOG.mdstays as a historical file.Release outcome
This is a
ci:commit, so on its own it isn't releasable. On merge, the commit analyzer still sees the unreleasedfeat/fixcommits sincev1.0.0and cuts 1.0.1.Tests
npm ci,npm run lint,npm run buildandnpm testpass locally on Node 22.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit