Repository navigation
Draw the 30 home parks from built-in fence distances - #20
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016uCcPyXxqRPqY3P5CNeNXF
src/data/venues.json, produced by the weekly data job on the live API, holds each club's park; the game page asks /venues only for others. Version 1.13.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016uCcPyXxqRPqY3P5CNeNXF
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/update-venues.mjs: writessrc/data/venues.json./teams?sportId=1&season=…, then fetches all 30 at once with/venues?venueIds=…&hydrate=fieldInfo, trimmed withfields=.update-player-data.yml):data/taiwan-playerstodata/weekly-update;src/utils/venues.ts): the alignment chart reads the built-in park first. It calls/venues/{id}only for parks outside the 30 clubs' homes, such as London or Tokyo games./venuesrequest it listed as a cost is gone.Where the data came from
venues.jsonwas produced by the updated workflow itself, run via workflow_dispatch on this branch against the live API. It was taken from thedata/weekly-updatebranch the run pushed; nothing was typed by hand.Test plan
npm test: 426 pass (4 new)./venuesrequest.Note
The old
data/taiwan-playersbranch is no longer written to and can be deleted.Generated by Claude Code