Skip to content

Let the player game log go back to earlier seasons - #19

Merged
VaalRL merged 2 commits into
mainfrom
claude/exciting-brown-osrche
Oct 19, 2026
Merged

VaalRL merged 2 commits into
mainfrom
claude/exciting-brown-osrche

Conversation

@VaalRL

@VaalRL VaalRL commented Oct 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • The player page game log gets a Season menu.
    • The first option is this season, whose log still loads with the page. After it come the earlier seasons the player has a line in, at any level, newest first.
    • The season list comes from stats(type=[yearByYear]), trimmed with fields= to the season numbers.
  • Picking a past season requests only that season:
    • the season's gameLog at every level, plus that year's postseason gameLog (getPlayerSeasonGameLogs);
    • the two are merged with the existing withPostseasonGameLogs, so the season gets the same sort, filters, totals and "show all" as before;
    • if the postseason part fails, the regular season still shows, with the existing postseason warning.
  • Filter and "show all" state is now kept per player + hitting/pitching + season.
  • Version 1.13.0, with changelog and TODO Phase 46.

Verified against the live API (contract tests, run on this branch via workflow_dispatch: all pass)

  • Ohtani's seasons come back newest first and include 2018, 2024 and 2025.
  • His 2024 log has 159 regular season games and 16 postseason games, all dated in 2024. The postseason request did not fail.

Test plan

  • npm test: 422 pass. A new page test covers the season options (deduplicated, newest first), switching to 2025 with its postseason row badged, and switching back.
    • One existing test counted the /people stats requests; it now leaves out the new season-list request.
  • build, lint (0 errors)
  • Screenshots at 1280px and 390px: the menu sits above the existing filters, and nothing overflows the page

Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016uCcPyXxqRPqY3P5CNeNXF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016uCcPyXxqRPqY3P5CNeNXF
@VaalRL
VaalRL merged commit 1f8e15a into main Oct 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants