Skip to content

Add a league transactions page - #17

Merged
VaalRL merged 2 commits into
mainfrom
claude/exciting-brown-osrche
Oct 19, 2026
Merged

VaalRL merged 2 commits into
mainfrom
claude/exciting-brown-osrche

Conversation

@VaalRL

@VaalRL VaalRL commented Oct 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • New #/transactions page with every big league club's moves over the last 7, 14 or 30 days (US Eastern dates).
    • Data: /transactions?sportId=1&startDate&endDate, trimmed with fields=. A busy week is about 900 moves.
    • Type filter: Key moves (the default) = trades + signings + departures. Signings = Signed as Free Agent, Signed, Signed as Draft Pick. Departures = Declared Free Agency, Released, DFA, Claimed Off Waivers, Retired. There is also an All option.
    • Team filter: matches either side of a move. Moves with no player are dropped. Moves are grouped by date, 60 at a time with "show more".
    • Moves of players from Taiwan (taiwan-players.json), of every type, are listed first. Chinese names show in the zh UI.
  • How to get there:
    • Navbar link from sm up; it is icon-only below xl so the bar still fits.
    • Home page link next to the level switcher; on a phone this is the only way in.
    • Measured at 320–1440px in zh and en: nothing overflows the page.
  • Version 1.11.0, with changelog and TODO Phase 44.

Verified against the live API (contract tests, run on this branch via workflow_dispatch)

  • The first week of November 2025 has 50+ moves, all dated inside the requested range, including Declared Free Agency.
  • Trade deadline week 2025 has 10+ trades, with big league clubs on both sides.
  • Type mix in those weeks: DFA is the code for Declared Free Agency, and DES for Designated for Assignment. The filters therefore key on typeDesc, not the code. Every type seen already has a Chinese label.

Test plan

  • npm test: 417 pass (11 new)
  • build, lint (0 errors)
  • Screenshots at 1280px and 390px

Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016uCcPyXxqRPqY3P5CNeNXF
Every big league club's moves over the last 7, 14 or 30 days, by type and
team, with moves of players from Taiwan first. Version 1.11.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016uCcPyXxqRPqY3P5CNeNXF
@VaalRL
VaalRL merged commit 6bae578 into main Oct 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants