Repository navigation
Add Chinese names for the remaining ten players from Taiwan - #14
Merged
Merged
Conversation
Names as reported by Taiwanese media (CNA, TVBS, UDN, World Journal): every player in taiwan-players.json now has one. Version 1.9.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016uCcPyXxqRPqY3P5CNeNXF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Chinese names for the 10 players from Taiwan that Phase 38 left unnamed. Each name is as reported by Taiwanese media (CNA, TVBS, UDN, World Journal, Taiwan News). Every player in
src/data/taiwan-players.jsonnow has a Chinese name, so all of them show it on the Players from Taiwan page and can be searched by it.Version 1.9.1, with changelog and TODO Phase 42.
Test plan
npm test: 394 passGenerated by Claude Code