Fix goversioninfo hook after Copilot dropped skip-versioninfo - #50
Merged
Merged
Conversation
Copilot Autofix removed -skip-versioninfo as a YAML list item, so the release hook failed looking for the default JSON. Put the skip flag on the go run line and ship a zeros JSON as fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-skip-versioninfofrom the GoReleaser hook, so goversioninfo tried to open a defaultversioninfo.jsonthat was not in the repo.akavel/rsrcdownload is goversioninfo's COFF writer library, not the old rsrc CLI.--skip-versioninfo=trueon thego runline (YAML-safe) and addinit/windows/versioninfo.jsonas a fallback.Test plan
v0.2.2(do not re-runv0.2.1; that tag still points at the broken hook and GitHub already created an empty release).versioninfo.json.0.2.2.<REVISION>in Explorer Properties.Made with Cursor