Skip to content

Rename updateAiConfig and fix doc comment - #3985

Merged
ryanwarfield merged 2 commits into
UBC-Thunderbots:masterfrom
ryanwarfield:ryan/fix-doc-comment-for-ai-updateaiconfig-consider-terminology-update
Oct 10, 2026
Merged

ryanwarfield merged 2 commits into
UBC-Thunderbots:masterfrom
ryanwarfield:ryan/fix-doc-comment-for-ai-updateaiconfig-consider-terminology-update

Conversation

@ryanwarfield

Copy link
Copy Markdown
Contributor

Description

updateAiConfig no longer updates the AI config, now it just sets a flag. Config updates happen through a shared pointer, the flag only matters for changes to the override play (needs a play fsm reset).

Testing Done

  • Ran play selection tests
  • Ran thunderscope

Resolved Issues

closes #3984

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@nycrat nycrat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ryanwarfield
ryanwarfield merged commit 2c6bee8 into UBC-Thunderbots:master Oct 10, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix doc comment for ai updateAiConfig

3 participants