Repository navigation
removed all instances of geneva - #3983
Open
noir-depresso wants to merge 10 commits into
Open
noir-depresso wants to merge 10 commits into
noir-depresso wants to merge 10 commits into
Conversation
noir-depresso
requested review from
Andrewyx,
StarrryNight,
nycrat,
sauravbanna and
williamckha
as code owners
October 10, 2026 16:55
Contributor
|
Looks like this PR contains commits from another PR. Consider re-targeting or stacking PRs if blocking? |
Andrewyx
reviewed
Oct 10, 2026
Andrewyx
left a comment
Andrewyx
left a comment
Contributor
There was a problem hiding this comment.
left some comments. Glad this cleanup is finally happening
Comment on lines
+143
to
+146
| float current_draw = 3; | ||
|
|
||
| uint32 sequence_num = 5; | ||
| bool breakbeam_tripped = 6; |
Contributor
There was a problem hiding this comment.
I don't think we need to as we will never be decoding old protos again
| switch (power_control.geneva_slot()) | ||
| { | ||
| case TbotsProto::Geneva::LEFT: | ||
| nanopb_control.geneva_slot = TbotsProto_Geneva_Slot_LEFT; |
| @@ -0,0 +1,6 @@ | |||
| load("@hedron_compile_commands//:refresh_compile_commands.bzl", "refresh_compile_commands") | |||
Contributor
There was a problem hiding this comment.
From this ticket or prev PR?
Contributor
Author
There was a problem hiding this comment.
yeah it was from a test i did, i got rid of it
|
|
||
| import "proto/robot_status_msg.proto"; | ||
| import "proto/geneva_slot.proto"; | ||
|
|
|
|
||
| ChickerControl chicker = 1; | ||
| Geneva.Slot geneva_slot = 2; | ||
| ChickerControl chicker = 1; |
|
|
||
| ChickerControl chicker = 1; | ||
| Geneva.Slot geneva_slot = 2; | ||
| ChickerControl chicker = 1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
removed all instances of geneva and passes bazel build //...Testing Done
Resolved Issues
resolves #3979Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue