Repository navigation
Fix image loading issue in docs - #3978
Merged
GrantYu9 merged 2 commits intoOct 6, 2026
Merged
Conversation
Images had incorrect file paths in `software-architecture-and-design`.
GrantYu9
requested review from
Andrewyx,
StarrryNight,
nycrat,
sauravbanna and
williamckha
as code owners
October 5, 2026 21:51
nycrat
reviewed
Oct 5, 2026
nycrat
left a comment
nycrat
left a comment
Member
There was a problem hiding this comment.
Nice catch! Glad to see someone reading the docs 😆
I think there are a few more instances of outdated image links, like for example in qt-best-practices.md so if you could also clean those up in this PR that would be great 🙏
Member
Author
Got it, will look into it! |
Numerous documentation files linked with `images/` instead of `/docs/images/`.
williamckha
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Background
Images had incorrect file paths in
software-architecture-and-design.Changes
Changed
images/to/docs/imagesin all image paths.Length Justification and Key Files to Review
Let us be in
/docs/. These files are of importance/getting_started/editing-the-docs.md/working_with_hardware/robot-software-architecture.md/working_with_software/qt-best-practices.md/working_with_software/software-architecture-and-design.mdReview Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue