Repository navigation
Remove the redundant layer "hl" - #3977
Merged
Merged
Conversation
StarrryNight
requested review from
Andrewyx,
nycrat,
sauravbanna and
williamckha
as code owners
October 4, 2026 20:48
StarrryNight
force-pushed
the
Remove_HL
branch
from
October 4, 2026 22:00
8e4bbdd to
58a8261
Compare
Contributor
|
Is this hash addition intended? I can't comment on that line in the PR: |
GrantYu9
reviewed
Oct 5, 2026
GrantYu9
approved these changes
Oct 5, 2026
StarrryNight
force-pushed
the
Remove_HL
branch
from
October 5, 2026 20:28
986a6ad to
3ae30d0
Compare
williamckha
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We currently have a redundant folder layer in the
softwaredirectory namedhl:e.g.
//software/ai/hl/stp/play:all_playsThe folder contains nothing but
stp, which contains all the skill tactics and play stuff.This PR removes the
hlfolder and movesstpup toai.Testing Done
bazel build \\software\...passesResolved Issues
#1917
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue