Repository navigation
Post-EKF robot localizer cleanup - #3957
Merged
Merged
Conversation
…ware into samuel/use_ekf_push
StarrryNight
marked this pull request as ready for review
September 30, 2026 01:52
StarrryNight
force-pushed
the
samuel/post_ekf_cleanup
branch
from
October 1, 2026 18:36
4fbb2c5 to
83c71ae
Compare
…tware into samuel/use_ekf_push
…Software into samuel/post_ekf_cleanup
williamckha
approved these changes
Oct 10, 2026
# Conflicts: # src/software/embedded/BUILD # src/software/embedded/primitive_executor.cpp # src/software/embedded/robot_localizer/robot_localizer.h # src/software/simulation/BUILD
taigooz
pushed a commit
to taigooz/Software
that referenced
this pull request
Oct 16, 2026
* dynamicaly compute matrices after vision rollback instead of using old estiamte * store post update/prediction state, instead of the state before for consistency * fix rollback cnsistency * generateMeasurementModel for better clarity in code * store enum instead of full matrix * reorder for clairy * remove filter step structs * keep removing filter step structs * Use mandatory FilterStepType insted of optionals checking * rename step to predict for discrete filters consistency * add getters for pev target velocities * wire up prediction * rely on control input for velcoity and predicted position * i thik works * add csv ogging * add testgin * x * implmeent process model * jacobian and integration * x * build * merge and se real ocalzer for plot juggler * fi logign * x * cleanup * q * [pre-commit.ci lite] apply automatic fixes * dynamicaly compute matrices after vision rollback instead of using old estiamte * store post update/prediction state, instead of the state before for consistency * fix rollback cnsistency * generateMeasurementModel for better clarity in code * store enum instead of full matrix * reorder for clairy * remove filter step structs * keep removing filter step structs * Use mandatory FilterStepType insted of optionals checking * rename step to predict for discrete filters consistency * add getters for pev target velocities * wire up prediction * rely on control input for velcoity and predicted position * implmeent process model * jacobian and integration * x * build * rebase * add csv ogging * add testgin * merge and se real ocalzer for plot juggler * fi logign * x * cleanup * q * [pre-commit.ci lite] apply automatic fixes * fix * [pre-commit.ci lite] apply automatic fixes * move folder * localizer constants * use variables * use constants * implemetnq * update path * add more constants and fix build * fix bug * [pre-commit.ci lite] apply automatic fixes * change tests to fit new model desgn * ix bug * [pre-commit.ci lite] apply automatic fixes * use variant and inheritted steps * clang * typo * funciton name * change names for clarity * comment * cleanup * [pre-commit.ci lite] apply automatic fixes * fix cast * [pre-commit.ci lite] apply automatic fixes * format * why was it like this * [pre-commit.ci lite] apply automatic fixes * fix bugs * fix build file location * [pre-commit.ci lite] apply automatic fixes * address comments --------- Co-authored-by: Thunderbots <ubcrobocup@gmail.com> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Merged by: Dorothy Wan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue