Re-render param badges in open menus on MIDI learn - #257
Merged
sastraxi merged 3 commits intoSep 9, 2026
Merged
Conversation
sastraxi
changed the title
sastraxi
changed the title
rreichenbach
approved these changes
Sep 8, 2026
rreichenbach
left a comment
rreichenbach
left a comment
Collaborator
There was a problem hiding this comment.
This seems to work with everything I tried.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when you opened up a plugin menu it would properly show badges i.e. (1/2/A/B/C/D) on bound parameter editors, but these badges did not update when changes are made e.g. via MIDI learn, or removing bindings in MOD-UI.
This PR fixes that by creating a binding "revision" that monotonically increases whenever a binding is updated. Each UI tick, plugin menus now compare the current revision to the current one being advertised; any difference wins (to account for overflow). Badges are then re-calculated and re-drawn, if required.