Correct the Value field help text - #35
Conversation
The hint said wei or decimal ETH, but the parser treats any non-0x input as decimal ETH — plain-integer wei was silently read as ETH. State the actual convention: decimal ETH, or 0x-prefixed hex wei.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward UI text correction that aligns the hint with the existing parsing convention and introduces no behavioral or API risk.
Pull request overview
Updates the UI guidance for the transaction “Value” input so it matches the actual parsing/behavior used for payable calls (decimal ETH unless 0x-prefixed, which is treated as hex wei), avoiding user confusion and accidental overpayment.
Changes:
- Corrected the Value field hint text to reflect the real input convention: decimal ETH (e.g.,
0.1) or0x-prefixed hex wei. - Aligns Simulation Overrides help text with the already-used wording for live payable value entry.
File summaries
| File | Description |
|---|---|
| src/components/SimulationOverridesPanel.tsx | Updates the Value field help text to accurately describe accepted formats (decimal ETH vs 0x hex wei). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The hint said "in wei or decimal ETH", but the parser treats any non-
0xinput as decimal ETH — a plain-integer wei amount was silently read as ETH. The hint now states the real convention (same as live payable calls since #34): decimal ETH, or0x-prefixed hex wei.