Repository navigation
Run Argon2 on the blocking pool in request handlers - #118
Merged
Merged
Conversation
Login, password changes, admin-created users, password resets and first-run setup hashed or verified passwords with Argon2 directly on the async runtime, holding a worker for tens of milliseconds per call. The password module gains off-runtime versions that use spawn_blocking; the handlers await them. Hash parameters and the constant-time login against a dummy hash are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Login, password changes, admin-created users, password resets and first-run setup hashed or verified passwords with Argon2 directly on the async runtime. Argon2 costs tens of milliseconds of CPU by design, so each call held a worker and stalled every other request scheduled on it.
think_watch_auth::passwordgainshash_password_off_runtime,verify_password_off_runtimeandverify_password_or_dummy_off_runtime, which run the existing functions withspawn_blocking.[Unreleased]Fixed entry.Testing
cargo clippy --workspace --all-targets -D warnings;cargo test -p think-watch-auth -p think-watch-server --lib(new test: the off-runtime versions agree with the blocking ones). Integration tests run in CI.🤖 Generated with Claude Code