Skip to content

Use admin UI v1.47.0 - #3779

Merged
dbernstein merged 1 commit into
mainfrom
chore/admin-ui-1.47.0
Sep 29, 2026
Merged

dbernstein merged 1 commit into
mainfrom
chore/admin-ui-1.47.0

Conversation

@dbernstein

Copy link
Copy Markdown
Contributor

Description

Bump the pinned @thepalaceproject/circulation-admin package version from 1.46.0 to
v1.47.0.

That release contains:

  • Clear all associated libraries after a successful save (PP-5153, #353)
  • Adopt library object building subclass hook to avoid duplication (#354)
  • Wait & show spinner when associated libraries still loading (PP-5030, #352)

Motivation and Context

New Palace Manager release should ship the current admin UI.

How Has This Been Tested?

Ran the admin config tests locally (tox -e py312-docker -- tests/manager/api/admin/test_config.py) — 32 passed. CI covers the rest.

Note: at the time this PR was opened, the v1.47.0 npm publish had not yet completed
(the admin repo's Test & Publish workflow for the tag was still running), so jsDelivr does
not resolve the new specifier yet:

$ curl -s "https://data.jsdelivr.com/v1/packages/npm/@thepalaceproject/circulation-admin/resolved?specifier=1.47.0"
{"type":"npm","name":"@thepalaceproject/circulation-admin","version":null,"links":{}}

This should be re-checked before merging to confirm the production package URL the manager
builds will serve real assets.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

🤖 Generated with Claude Code

Bump the pinned @thepalaceproject/circulation-admin package version
from 1.46.0 to 1.47.0.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@claude

claude Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @dbernstein's task in 31s —— View job


Summary

This is a one-line bump of Configuration.PACKAGE_VERSION from 1.46.0 to 1.47.0 in src/palace/manager/api/admin/config.py. It follows the usual admin-UI bump pattern and I found no issues. No tests, docs or README mention the old version; 1.46.0 appeared only on this line. The version stays overridable at runtime through TPP_CIRCULATION_ADMIN_PACKAGE_VERSION. The PR description asks for a re-check before merging, and I couldn't do it: this job's sandbox blocked outbound requests, so I could not confirm that jsDelivr now resolves 1.47.0. Production builds load assets from https://cdn.jsdelivr.net/npm/@thepalaceproject/circulation-admin@1.47.0/dist/, and those URLs return 404 until the npm publish finishes. Please re-run the curl from the description before merging.

  • Gather context (PR diff)
  • Check for other references to the admin UI version (tests, docs, README)
  • Verify the npm package for v1.47.0 is published (blocked: this job can't make outbound HTTP or cross-repo gh calls)
  • Post review

@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Low risk] Bumps the admin UI package version.

The change is non-blocking from the available code evidence, but the published assets should be verified before deployment.

Findings

  1. P2 Unverified admin assets ▶

Summary

The PR changes the default admin UI package from 1.46.0 to 1.47.0. Production asset URLs will select the new release unless a deployment overrides the version.

  • Verify the published assets as a release gate; URL-construction tests cannot establish their availability.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Default version 1.47.0] --> B[Production CDN asset URLs]
  B --> C[Admin page JavaScript and CSS]
Loading

Reviews (1) · Last reviewed commit: "Use admin UI v1.47.0"

APP_NAME = "Palace Collection Manager"
PACKAGE_NAME = "@thepalaceproject/circulation-admin"
PACKAGE_VERSION = "1.46.0"
PACKAGE_VERSION = "1.47.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Unverified admin assets

The new default is used directly in the production URLs for the admin JavaScript and CSS, but the tests check only how those URLs are built. If version 1.47.0 has not been published when this is deployed, the admin page will load without its application. Please verify that the published assets are available before deployment.

Knowledge Base Used: Administration and configuration

@dbernstein
dbernstein merged commit 5dde763 into main Sep 29, 2026
22 checks passed
@dbernstein
dbernstein deleted the chore/admin-ui-1.47.0 branch September 29, 2026 17:40
@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.74%. Comparing base (374c35c) to head (a917056).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3779   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files         510      510           
  Lines       46417    46417           
  Branches     6300     6300           
=======================================
  Hits        43515    43515           
  Misses       1874     1874           
  Partials     1028     1028           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant