🐛 Fix recursion in count_padding - #432
Open
Thalhammer wants to merge 2 commits into
Open
Thalhammer wants to merge 2 commits into
Thalhammer wants to merge 2 commits into
Conversation
prince-chrismc
approved these changes
Sep 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes count_padding to no longer work recursive.
It also changes behaviour to not allow non-uniform padding.
I.e. the padding symbol should stay the same for the entire encoded string.
The previous implementation allowed any padding symbol as long as its part of the accepted set, however this is not following the base64 spec.
Now the padding symbols are required to be identical.