fix: narrow browser and extension boundaries / 收窄浏览器与扩展边界 - #38
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The functional changes align with the stated acceptance criteria and the remaining review notes are minor repository-hygiene improvements.
Pull request overview
This PR upgrades the project’s Calcit/Respo dependency chain and tightens browser/extension host boundaries by introducing typed external-object traits and Option-based narrowing at ingress, while also migrating the Calcit quality baseline from compiler-owned JSON to generated Cirru EDN and enforcing stricter Caps resolution in CI.
Changes:
- Bump Calcit/@calcit/procs and Respo stack versions; align app versioning to
0.0.4. - Introduce typed host-boundary traits and safer narrowing for focus events, document visibility, and extension messages (extension actions flow as
Option<String>). - Replace
config/calcit-quality.jsonbaseline with generatedconfig/calcit-quality.cirru, and update CI to usecaps --strictplus the new baseline path.
File summaries
| File | Description |
|---|---|
| yarn.lock | Updates lockfile to reflect upgraded dependency versions (notably @calcit/procs@0.13.75). |
| package.json | Bumps @calcit/procs and aligns package version to 0.0.4. |
| deps.cirru | Updates Calcit and Respo dependency versions and project version metadata. |
| calcit.cirru | Adds typed browser/extension traits, refactors focus handling via toggle-focus-within!, narrows visibility/action values, and updates return schemas. |
| config/calcit-quality.json | Removes the legacy JSON quality baseline. |
| config/calcit-quality.cirru | Adds the generated Cirru EDN quality baseline used by CI. |
| .github/workflows/upload.yaml | Enforces caps --strict --ci and points quality checks at the Cirru baseline. |
| .gitattributes | Marks the new quality baseline as generated text for GitHub linguist handling. |
| history/202609030040-typed-host-boundaries.md | Records the rationale and validation steps for the typed-boundary and baseline migration. |
Review details
- Files reviewed: 8/9 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tiye
force-pushed
the
codex/strict-dependency-chain-20260903
branch
from
September 2, 2026 16:57
9fb24d0 to
7c99ef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English
Closes #37.
What changed
Option<String>.package.jsonto project version 0.0.4, addressing the unresolved review note from PR chore: upgrade Calcit 0.13.73 and Respo 0.16.88 / 升级依赖链 #35.The seven current-compiler warnings from #37 are eliminated. Unresolved totals move 84 → 83 and schema Dynamic moves 64 → 63; the existing 20 nil sites remain budgeted for staged cleanup.
Validation
caps --strictcaps verify --toolchainyarn install --immutablecalcit edit formatwith no additional Snapshot diffcalcit --check-onlywith zero preprocessing warningscalcit analyze quality --baseline config/calcit-quality.cirrucalcit analyze dynamic-methods --summary-only --format jsoncalcit test: 5 passedcalcit js中文
关闭 #37。
修改
Option<String>进入应用控制流。package.json对齐到项目版本 0.0.4,落实 PR chore: upgrade Calcit 0.13.73 and Respo 0.16.88 / 升级依赖链 #35 尚未处理的 review 意见。#37 的 7 条当前编译器告警已清零。unresolved 总数从 84 降到 83,schema Dynamic 从 64 降到 63;既有 20 个 nil 位置继续按阶段清理。
验证
caps --strictcaps verify --toolchainyarn install --immutablecalcit edit format无额外 Snapshot diffcalcit --check-only零 preprocessing warningcalcit analyze quality --baseline config/calcit-quality.cirrucalcit analyze dynamic-methods --summary-only --format jsoncalcit test:5 passedcalcit js