Skip to content

fix(QTDI-3430): [TCK] NPM Security updates 1.26.10 - #1279

Open
undx wants to merge 12 commits into
masterfrom
ouf/QTDI-3430-cve-npm
Open

fix(QTDI-3430): [TCK] NPM Security updates 1.26.10#1279
undx wants to merge 12 commits into
masterfrom
ouf/QTDI-3430-cve-npm

Conversation

@undx

@undx undx commented Sep 14, 2026

Copy link
Copy Markdown
Member

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Critical dependency override conflicts and missing direct dependency declarations remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Security refresh of frontend npm dependencies and lockfiles across documentation, component tools, and starter server modules.

Changes:

  • Updates js-yaml, UI, router, and transitive dependencies.
  • Adds security-related dependency overrides.
  • Regenerates frontend lockfiles.
File summaries
File Summary
documentation/src/main/frontend/package-template.json Updates dependency overrides.
documentation/src/main/frontend/package-lock.json Refreshes locked dependencies.
component-tools-webapp/src/main/frontend/package.json Updates dependencies; moderate issue (2 votes): retain direct @talend/icons dependency.
component-tools-webapp/src/main/frontend/package-template.json Critical issue (1 vote): unscoped postcss-selector-parser override conflicts with declared 7.x ranges. Moderate issue (3 votes): retain direct @talend/icons dependency.
component-tools-webapp/src/main/frontend/package-lock.json Refreshes resolved dependencies.
component-starter-server/src/main/frontend/package.json Updates dependencies and overrides.
component-starter-server/src/main/frontend/package-template.json Critical issue (1 vote): unscoped postcss-selector-parser override conflicts with declared 7.x ranges.
component-starter-server/src/main/frontend/package-lock.json Refreshes resolved dependencies.
Review details

Files not reviewed (3)

  • component-starter-server/src/main/frontend/package-lock.json: Generated file
  • component-tools-webapp/src/main/frontend/package-lock.json: Generated file
  • documentation/src/main/frontend/package-lock.json: Generated file
  • Files reviewed: 5/8 changed files
  • Comments generated: 4
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread component-starter-server/src/main/frontend/package-template.json Outdated
Comment thread component-tools-webapp/src/main/frontend/package-template.json Outdated
Comment thread component-tools-webapp/src/main/frontend/package-template.json
Comment thread component-tools-webapp/src/main/frontend/package.json

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Resolve the incompatible postcss-selector-parser override and restore direct runtime dependencies for imported packages.

Get a fresh assessment by requesting another Copilot review.

Review details

Files not reviewed (3)

  • component-starter-server/src/main/frontend/package-lock.json: Generated file
  • component-tools-webapp/src/main/frontend/package-lock.json: Generated file
  • documentation/src/main/frontend/package-lock.json: Generated file

Suppressed comments (2)

Previously missed (1) — in code that hasn't changed since the last review.

component-tools-webapp/src/main/frontend/package-template.json:14

  • This generated template removes both @talend/react-cmf and @talend/icons from the app's direct runtime dependencies, even though the application still imports them in src/app/index.js, src/app/components/Detail/Detail.connect.js, and src/app/store/componentsList/actions.js. Because this template overwrites package.json during the Maven build, the resulting project relies on transitive packages in the lockfile and can fail with module-not-found after a transitive update or different install layout; keep both packages declared directly and regenerate the lockfile.

component-tools-webapp/src/main/frontend/package.json:14

  • These dependency changes remove both @talend/react-cmf and @talend/icons from the app's direct runtime dependencies, even though the application still imports them in src/app/index.js, src/app/components/Detail/Detail.connect.js, and src/app/store/componentsList/actions.js. They are currently available only through transitive packages in the lockfile, so a future transitive update or a different install layout can make the build fail with module-not-found; keep both packages declared directly and regenerate the lockfile.
    "@talend/bootstrap-theme": "^9.2.0",
    "@talend/design-system": "^11.8.0",
    "@talend/react-components": "^17.5.0",
    "@talend/react-containers": "^11.0.4",
    "@talend/react-forms": "^15.0.2",
  • Files reviewed: 5/8 changed files
  • Comments generated: 2
  • Review effort level: Lite

Comment thread component-starter-server/src/main/frontend/package-template.json Outdated
Comment thread component-tools-webapp/src/main/frontend/package-template.json Outdated
@undx undx self-assigned this Sep 14, 2026
@undx undx added the cve label Sep 14, 2026
@undx
undx requested a lite review from Copilot September 14, 2026 09:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Direct @talend/react-cmf imports remain while the dependency was removed from the webapp manifests.

Get a fresh assessment by requesting another Copilot review.

Review details

Files not reviewed (3)

  • component-starter-server/src/main/frontend/package-lock.json: Generated file
  • component-tools-webapp/src/main/frontend/package-lock.json: Generated file
  • documentation/src/main/frontend/package-lock.json: Generated file
  • Files reviewed: 5/8 changed files
  • Comments generated: 2
  • Review effort level: Lite

Comment thread component-tools-webapp/src/main/frontend/package-template.json
Comment thread component-tools-webapp/src/main/frontend/package.json
@undx
undx requested a review from thboileau September 14, 2026 11:57
@sonar-rnd

sonar-rnd Bot commented Sep 14, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants