Repository navigation
Skip late tick sounds after the round-change alert - #516
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I observe
With tick sounds on, when a work round ends and the break starts, the first few ticks of the break play rushed together. After that, the ticks go back to one per second.
What I think causes it
I don't have experience with Rust or Tauri, so please correct me if I've misread this.
The audio thread in
src-tauri/src/audio/mod.rsplays one sound at a time and waits for each one to finish (sleep_until_end). The round-change alert is about 3 seconds long. The ticks requested during those 3 seconds wait in the channel, then play back-to-back once the alert ends.The change
Each play request now records when it was made. The audio thread skips a tick if it is more than 500 ms late. Alerts are never skipped.
As a side effect, no ticks play while the alert is playing. After the alert, ticks resume on schedule.
A fuller fix would mix sounds so ticks play over the alert. I kept this one small on purpose.
Testing
cargo testpasses.