Bump sha2 to 0.11 and stop relying on LowerHex - #15
Merged
Merged
Conversation
Dependabot's bump failed to compile: sha2 0.11 changed finalize() to
return a type that no longer implements LowerHex, so
`format!("{:x}", hasher.finalize())` stopped building.
The fix is to write the hex encoding out rather than lean on a trait impl
that the crate is free to change. Worth noting the compiler caught this —
the same shorthand produces the STORED key_hash in
Sentinel-License-Service, where a silently different encoding would
orphan every license row instead of failing the build.
Supersedes the Dependabot PR, which could not carry the call-site change.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot's bump (#14) failed to compile:
sha2 0.11 changed
finalize()to return a type that no longer implementsLowerHex. The fix is to write the hex encoding out rather than lean on atrait impl the crate is free to change.
Worth noting the compiler caught this. The same shorthand produces the
stored
key_hashin Sentinel-License-Service — a silently differentencoding there would orphan every license row rather than fail the build. That
service pins its hashing to a fixed vector (
sha256("slk_test")) for exactlythis reason.
Supersedes #14, which couldn't carry the call-site change.
🤖 Generated with Claude Code