Bump sysinfo, rusqlite, crossterm and indicatif - #35
Merged
Conversation
Four of the five open Cargo bumps, taken together because they share no API surface and the compiler checks all of them at once: sysinfo 0.30.13 -> 0.39.6 (#20) rusqlite 0.31.0 -> 0.40.2 (#28) crossterm 0.27.0 -> 0.29.0 (#24) indicatif 0.17.11 -> 0.18.6 (#23) No source changes were needed. The two that looked most likely to break did not: this tree uses only `System::host_name()`, `Disks` and `sysinfo::Disk` from sysinfo, and only `params`, `Connection`, `Row` and `Result` from rusqlite — narrow enough that nine and nine minor versions of churn pass straight through. Verified locally with the same gates test.yml runs: cargo build --locked exit 0 cargo clippy --all-targets --locked exit 0, 30 warnings cargo test --locked 241 passed, 0 failed, 1 ignored cargo audit 1 allowed warning The 30 clippy warnings are pre-existing doc and style lints in our own code; none of them reference the bumped crates, and none is a deprecation notice from the new versions. indicatif 0.18 drops `number_prefix`, which clears one of the two `unmaintained` advisories test.yml's comment lists. fxhash remains, and is unchanged by this. windows-service 0.8 (#25) is deliberately NOT here. It only compiles under `cfg(target_os = "windows")`, test.yml runs ubuntu-only, and cross-compiling to x86_64-pc-windows-msvc fails locally in ring's build script with no MSVC toolchain available. Bumping it here would mean shipping an unverified change into the binary customers install. It needs a Windows CI leg first. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sbussiso
added a commit
that referenced
this pull request
Sep 13, 2026
Everything under cfg(target_os = "windows") was invisible to CI: src/service.rs — the entire Windows Service entry point — plus the windows-service and tracing-appender dependencies and every Windows branch in the platform modules. test.yml runs ubuntu-only, so the only thing that ever compiled that code was release.yml, on a tag, after the decision to ship had already been made. The gap had teeth. windows-service 0.7 -> 0.8 (#25) could not be reviewed at all: ubuntu CI reported green without compiling a line of what the bump affects, and cross-compiling to x86_64-pc-windows-msvc fails locally in ring's build script with no MSVC toolchain available. For a binary that installs onto customers' own machines as a Windows Service, release time is the wrong moment to discover that. Adds a `windows` job on windows-latest running build + clippy. A full build rather than `check`, because linking is part of what can break when windows-service resolves Service Control Manager entry points — a check would type-check those and never link them. No `cargo test` on Windows: `--all-targets` already type-checks the test code, which is what catches a Windows-only compile regression. Running the suite there means triaging tests that assume POSIX paths and a present ffmpeg — worth doing, not worth coupling to this. Also drops number_prefix from the cargo-audit comment's list of unmaintained crates; indicatif 0.18 stopped depending on it in #35. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four of the five open Cargo bumps, taken together because they share no API
surface and one compile checks all of them.
sysinforusqlitecrosstermindicatifNo source changes were needed. The two that looked most likely to break
didn't, because this tree's usage is narrow: only
System::host_name(),Disksandsysinfo::Diskfrom sysinfo, and onlyparams,Connection,RowandResultfrom rusqlite. Nine and nine minor versions of churnpass straight through that surface.
Verified locally, with the gates
test.ymlactually runscargo build --lockedcargo clippy --all-targets --lockedcargo test --lockedcargo auditThe 30 clippy warnings are pre-existing doc/style lints in our own code
(
doc list item overindented×13, and similar). None references the bumpedcrates and none is a deprecation notice from a new version.
A small win
indicatif0.18 dropsnumber_prefix, which clears one of the twounmaintainedadvisories thattest.yml's comment lists.fxhashremainsand is unchanged by this.
Why windows-service #25 is not in here
windows-service0.8 only compiles undercfg(target_os = "windows").test.ymlruns ubuntu-only, so neither it norsrc/service.rsiscompiled by any CI job — only by
release.ymlon a tag. I tried to verifyit locally and
cargo check --target x86_64-pc-windows-msvcfails inring's build script with no MSVC toolchain available (and mingw isn'tinstalled).
Merging it here would ship an unverified change into the binary customers
install on their own hardware, which is exactly what this repo's
dependabot.ymlsays not to do. It needs a Windows CI leg first — filedseparately.
Closes #20
Closes #23
Closes #24
Closes #28
🤖 Generated with Claude Code