Make workflow_dispatch a real dry run of the binary build - #32
Merged
Merged
Conversation
The Windows MSI only builds on a Windows runner, so wix/main.wxs changes are invisible locally. The 2026-09-09 cloudnode rename touched that file in 25 places, and there was no way to verify it short of tagging a release and hoping. `workflow_dispatch` existed but did not help: `build` was gated on `github.event_name == 'push'`, so dispatch skipped the entire binary matrix and ran only docker-publish. That Docker run is a deliberate smoke test and a good one — it pushes a `sha-` tag, and `latest` is semver-only so nothing gets clobbered — but it verified nothing about the binaries or the installer package. `build` now also runs on dispatch. `release` stays tag-only, so a dispatch compiles every target — Linux x86_64/aarch64/armv7, macOS x86_64/aarch64, and the Windows MSI — and publishes no GitHub release. Packaging changes can now be proven before a version number is spent. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows MSI only builds on a Windows runner, so
wix/main.wxschanges are invisible locally. The cloudnode rename touched that file in 25 places, and there was no way to verify it short of tagging a release and hoping.workflow_dispatchexisted but didn't help:buildwas gated ongithub.event_name == 'push', so dispatch skipped the entire binary matrix and ran onlydocker-publish.That Docker run is a deliberate smoke test and a good one — it pushes a
sha-tag, andlatestis semver-only so nothing gets clobbered. But it verified nothing about the binaries or the installer package.buildnow also runs on dispatch.releasestays tag-only, so a dispatch compiles every target — Linux x86_64/aarch64/armv7, macOS x86_64/aarch64, and the Windows MSI — and publishes no GitHub release.Packaging changes can now be proven before a version number is spent.
🤖 Generated with Claude Code