Restrict /apply-optimize workflow to trusted authors

[ctorres100]

Summary

Harden .github/workflows/skill-optimize-apply.yml against a CI privilege-escalation path.

The workflow triggers on issue_comment and runs with contents: write + pull-requests: write, checks out the repo (fetch-depth: 0), and hands off to a third-party action (tesslio/skill-review-and-optimize) in apply mode. The only gate was:

if: github.event.issue.pull_request && contains(github.event.comment.body, '/apply-optimize')

On a public repo, any GitHub user can post a comment containing /apply-optimize, so any outsider could invoke this write-capable job.

Fix

Add an author_association check so only OWNER, MEMBER, or COLLABORATOR can trigger it:

if: >
  github.event.issue.pull_request &&
  contains(github.event.comment.body, '/apply-optimize') &&
  contains(fromJSON('["OWNER", "MEMBER", "COLLABORATOR"]'), github.event.comment.author_association)

No behavior change for maintainers; external commenters can no longer start the job.

Notes / related findings (not in this PR)

While reviewing the repo I also noted, for separate follow-up:

• convert_skills.py auto-runs pip install pyyaml on import, using bare pip — and yaml is never actually used in the script (dead dependency block).
• python-publish.yml builds a package on release but the repo has no pyproject.toml/setup.py.

Happy to send these as their own PRs if wanted.

🤖 Generated with Claude Code

[ctorres100]

Closing at author's request.