Pin edge-apps-actions to v26.9.0 tag - #37
Open
nicomiguelino wants to merge 1 commit into
Open
Conversation
Switching from a pinned commit hash to the v26.9.0 version tag is intentional, for easier reference. v26.9.0 points to the exact same commit that was previously pinned by hash, so this is not a reduction in supply-chain safety — it is a readability change, not a move to a floating/unpinned reference.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Pinning Actions to a tag instead of an immutable commit SHA is a supply-chain security regression (tags can be retargeted upstream), which also contradicts the PR description’s safety claim.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates GitHub Actions workflow references for Screenly/edge-apps-actions from a pinned commit SHA to the v26.9.0 release tag to improve readability and cross-referencing.
Changes:
- Switch
Screenly/edge-apps-actions/updatefrom a pinned SHA tov26.9.0in the update workflow (stage + production). - Switch
Screenly/edge-apps-actions/initializefrom a pinned SHA tov26.9.0in the initialization workflow.
File summaries
| File | Description |
|---|---|
| .github/workflows/update-edge-app.yml | Updates the update reusable action reference to v26.9.0 for stage and production deployments. |
| .github/workflows/initialize-edge-app.yml | Updates the initialize reusable action reference to v26.9.0 for manual initialization runs. |
Review details
Suppressed comments (1)
.github/workflows/update-edge-app.yml:35
- This workflow step is now pinned to a tag rather than an immutable commit SHA; tags can be moved upstream, changing what runs. Consider restoring the SHA and adding the tag as an inline comment for readability.
- uses: Screenly/edge-apps-actions/update@v26.9.0
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenly/edge-apps-actionsreusable actions are switched from the pinned 40-character commit hash (f4ccd2bd50db5fb0a5147d287ac03cafe552d29b) to thev26.9.0release tag.Why
v26.9.0points to the exact same commit that was previously pinned by hash (see https://github.com/Screenly/edge-apps-actions/releases/tag/v26.9.0), so this does not change which code runs.