Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a document is shorter than the viewer, such as a single Letter page on a phone,
PdfViewPinchsizes itsInteractiveViewerchild to the pages, which leaves the child smaller than the viewport.InteractiveViewerwon't scale that child below the point where it covers the viewport, so the first pinch jumps to about 1.5× and the page can't be zoomed back out to fit.#487 worked around this by removing the pan bounds; since #529 that only applies when
minScale < 1, so the default viewer has the problem again. This fixes it with the bounds kept: a short document is centered and the laid-out document is always at least the size of the viewport. Zoom now starts at fit and pinching out returns to it. The horizontal layout gets the same treatment.To reproduce: open a one-page PDF in
PdfViewPinch, pinch in, then pinch out.