Repository navigation
test: hold the vertical coupled-torsion lines taut - #13
Merged
Merged
Conversation
The PtfmInit and FAST.Farm checks of coupled_torsion hang a neutrally buoyant 100 m line under the fairlead with its anchor exactly 100 m below, so the static solve starts from zero tension, where it has no catenary seed and its result depends on round-off. With OPENBLAS_CORETYPE=Prescott (the workaround for the OpenBLAS 0.3.34 modal crash) the FAST.Farm check failed deterministically: the mesh-sequenced fallback stopped on a kinked state. The anchor now sits 0.5 m lower, so the line hangs taut at 0.5 % strain; the twist and torque checks are unchanged (the torsion compliance uses the unstretched length) and pass with the default, Prescott, Haswell and SkylakeX kernels. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coupled_torsion(added in #11) fails deterministically whenOPENBLAS_CORETYPE=Prescottis set, which is the documented workaround for the OpenBLAS 0.3.34 modal crash.The PtfmInit (6) and FAST.Farm (8) checks hang a neutrally buoyant 100 m line under the fairlead, with its anchor exactly 100 m below. The static solve therefore starts from zero tension, where it has no catenary seed and its result depends on round-off. Under the Prescott kernels, check 8 stops in the mesh-sequenced fallback on a kinked state:
The anchor now sits 0.5 m lower, so the line hangs taut at 0.5 % strain. The twist and torque checks are unchanged: the torsion compliance uses the unstretched length, and the values are identical (Twist1 15° and 10°, Torq 130.90 and 87.27 N·m). No solver code changes.
Tests
test_coupled_torsion:PrescottHaswellSkylakeXpre-commit run --all-filespasses.Checklist
pre-commit run --all-filespassesctest --test-dir build --output-on-failurepasses (the changed test, with four OpenBLAS kernels)python -m pytest tests python/testspasses (if Python or validation records changed) — not applicable[Unreleased](heading added if missing) for user-visible changes — not user-visibledoc/updated for changed inputs, options, or outputs — not applicablefeat:,fix:,docs:, ...)git commit -s) under theDeveloper Certificate of Origin