Repository navigation
fix: create mTLS private key temp files with owner-only permissions - #453
Merged
Merged
Conversation
PemFileCreator previously used File.createTempFile, which creates files with permissions determined by the process umask. On systems with a permissive umask (e.g. 022), the private key files were world-readable until the JVM process exited and deleted them. Switch to Files.createTempFile with a PosixFilePermissions attribute of rw------- so the file is created with owner-only read/write permissions atomically, eliminating the race window. A fallback for non-POSIX filesystems (Windows) uses File.setReadable/setWritable to restrict access after creation. Signed-off-by: Karsten Schnitter <k.schnitter@sap.com>
KarstenSchnitter
requested review from
Felix-Griesau-SAP,
dkhsap and
nicklas-dohrn
October 14, 2026 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PemFileCreator previously used File.createTempFile, which creates files with permissions determined by the process umask. On systems with a permissive umask (e.g. 022), the private key files were world-readable until the JVM process exited and deleted them.
Switch to Files.createTempFile with a PosixFilePermissions attribute of rw------- so the file is created with owner-only read/write permissions atomically, eliminating the race window. A fallback for non-POSIX filesystems (Windows) uses File.setReadable/setWritable to restrict access after creation.