Repository navigation
Restart unless stopped - and fix lots of bit-rot. - #194
Merged
Merged
Conversation
The mailserver docker container doesn't automatically restart like the rest of them do (e.g. reboot, docker daemon restart, etc).
Updated Composer configuration to block policy advisories instead of ignoring them.
Updated UserMerge extension checkout to a specific commit instead of the branch.
hcooper
requested review from
BenjaminPelletier,
catware2,
dangel-ma and
davantalus
August 30, 2026 20:46
This was referenced Aug 30, 2026
Merged
BenjaminPelletier
approved these changes
Aug 31, 2026
BenjaminPelletier
left a comment
BenjaminPelletier
left a comment
Member
There was a problem hiding this comment.
docker build cache was failing to pick up dockerfile changes, so disabled it during tests (also force pulling of images).
That seems particularly weird, but I'm not at all bothered by --no-cache --pull here
| audit.ignore "PKSA-t71x-qf1n-7xwy" \ | ||
| audit.ignore "PKSA-z3gr-8qht-p93v" \ | ||
| audit.ignore "PKSA-4s4z-t146-6123" | ||
| RUN COMPOSER_ALLOW_SUPERUSER=yes composer config --no-plugins --json policy.advisories.block false |
Member
There was a problem hiding this comment.
nit: a TODO note or Issue might help us track the eventual definitive resolution
Contributor
Author
There was a problem hiding this comment.
There's one on the line above :-D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All I wanted was for the mailserver container to have
restart: unless-stoppedenabled (so it automatically restarts after reboot like all the other containers.However I ran into so much bit-rot that needed fixing:
Pages of new security advisories blocking
composer, rather than just adding to the list of exclusions I've disabled checking until we're up to date, as there's no other action to take. This applies to the Sphinx extension too.docker build cache was failing to pick up dockerfile changes, so disabled it during tests (also force pulling of images).
pear install mailkept failing, pear site seems very slow but working, just switched to the apt packages.UserMergegithub report deleted old tags/branches, switched to gerrit which still had REL1_39 tag.Found out about
docker-compose.override.yaml, added to git ignore. It lets me override some stuff locally as I have complex container network setup.I'll make another PR to run the github tests on a schedule (not just on a PR) so these breakages get flagged sooner.