Repository navigation
Conversation
Escape HTML link text and attributes and reject unsafe URL schemes. Restrict interpolated feed-settings SQL identifiers to known columns, with regression coverage for HTML injection. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Why closed? |
Author
|
I'm one of those hapless vibe coders you probably hate. Unintentional. Apols. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feed and author metadata can be untrusted, so interpolating it into generated HTML risks injection. This hardens generated links by escaping text and attributes and allowing only HTTP, HTTPS, and mailto schemes. Feed settings updates now also validate interpolated SQL column identifiers against the defined columns.
Adds regression coverage for escaped HTML, rejected JavaScript URLs, and accepted mailto links. Targeted Swift tests could not be run because the installed Swift Package Manager aborts with a BuildServerProtocol dynamic library mismatch.