Repository navigation
fix: thread sync stalls on nul characters, and updates skip migrations - #249
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ew version Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs found while deploying #237–#248 to the always-on machine:
\u0000in neithertextnorjsonb, and agents' terminal output contains it. On the live machine, one such event made every round fail withunsupported Unicode escape sequence. Only 4 of 54 threads ever reached the database. The API now swaps NUL for U+FFFD in strings and keys before writing. A new test inroutes.test.tsfails without the fix and passes with it.scripts/bash/update-grid.sh(Settings → Machines → Update) installed and built the new release but never randb:migrate, andbun run startdoesn't migrate either. An update that adds tables (such as 0014/0015 for thread sync) would therefore start against a database without them. There's now amigratingstep after the build and before the switch. A failure there leaves the running version untouched, as with a failed build.🤖 Generated with Claude Code