Conversation
|
The change to Of note, this file is typically generated from the self-documentation provided by the various components, and it seems that you also updated that in |
|
Hi Chunyu, have you had an opportunity to run ARAX locally and check that it functions as expected after all of these removals/edits?? Happy to help with that if needed. |
|
Hi Frankie @hodgesf, I didn't deploy ARAX locally but only run all non-slow tests, I would greatly appreciate if you could help with checking. Thank you! |
|
@chunyuma regarding the DSL documentation, this is autogenerated via https://github.com/RTXteam/RTX/blob/master/code/ARAX/Documentation/document_dsl_commands.py. Is that what you ran to make the DSL markdown document edits? If not, you likely don't want to manually edit the DSL documentation, as it will get stomped on the next time the |
|
@dkoslicki, it is not autogenerated via script but should be exactly the same because the removed part in the document is all from the old xCRG module (which has been entirely removed including its document content). I show it here to let you know what was updated in the document. |
Hi all,
This PR was created to clean up the dead code/files associated with old xCRG which involves the following scripts.
Notes
ARAX_expander.py(4 underFile edited) andRTXConfiguration.py(5 underFile edited). My apologies for tagging you if you are not responsible for these files, and thank you for your understanding.araxi.js(7 underFile edited)? I would appreciate your help.DSL_Documentation.md(6 underFile edited) andtest_ARAX_infer.py(3 underFile edited)? I would appreciate your help.Could you all please make sure these changes look good, although they now have passed the non-slow tests? I appreciate everybody's help.
Files Deleted
code/ARAX/ARAXQuery/Infer/scripts/creativeCRG.pycode/ARAX/ARAXQuery/Infer/scripts/refresh_CRG_data.pycode/ARAX/ARAXQuery/Infer/README.mdxCRG_data/decreased_NGD_score_dist.pngxCRG_data/decreased_prob_dist.pngxCRG_data/increased_NGD_score_dist.pngxCRG_data/increased_prob_dist.pngxCRG_data/chemical_gene_embeddings_v1.0.KG2.10.0_refreshedTo_KG2.10.2.npzxCRG_data/xcrg_increase_model_v1.0.KG2.10.0_new_version.ptxCRG_data/xcrg_decrease_model_v1.0.KG2.10.0_new_version.ptFiles Edited
1.
code/ARAX/ARAXQuery/ARAX_infer.pyWhat was removed:
from creativeCRG import creativeCRGimportfrom openapi_server.models.qualifier import Qualifier/QualifierConstraintimports (only used by xCRG)'chemical_gene_regulation_graph_expansion'fromallowable_actionssetxcrg_subject_curie_info,xcrg_object_curie_info,xcrg_subject_qnode_id,xcrg_object_qnode_id,xcrg_qedge_id_info,xcrg_regulation_type,xcrg_n_result_curies_info,xcrg_threshold,xcrg_kp,xcrg_path_len,xcrg_n_paths_info)command_definitions['chemical_gene_regulation_graph_expansion']block__chemical_gene_regulation_graph_expansion()method2.
code/ARAX/ARAXQuery/Infer/scripts/infer_utilities.pyWhat was removed:
genrete_regulate_subgraphs()method — built TRAPI knowledge graphs from old xCRG predictions3.
code/ARAX/test/test_ARAX_infer.pyWhat was removed:
test_xcrg_infer_bomeol— tested DSL-based xCRG with subject chemicaltest_xcrg_with_qg1— tested xCRG with query graph (gene pinned)test_xcrg_with_qg2— tested xCRG with query graph (chemical pinned, decreased direction)test_xcrg_with_only_qg— tested xCRG with TRAPI-only query (no DSL)test_xcrg_infer_dsl— tested xCRG with DSL + overlay + resultify pipeline4.
code/ARAX/ARAXQuery/ARAX_expander.pyWhat was removed:
elif set(["biolink:affects"]).intersection(set(qedge.predicates))block — this was the old routing path that dispatched inferredbiolink:affectsqueries toARAXInferforchemical_gene_regulation_graph_expansion. It is safe to be deleted. TheARAX_query_graph_interpreter.pynow intercepts all xCRG-eligible queries viais_xcrg_mvp2_query()and routes them toconnect(action=xcrg)before they ever reachARAX_expander.py.5.
code/RTXConfiguration.pyWhat was removed:
legacy_xcrg_data_dirvariableself.xcrg_embeddings_pathattributeself.xcrg_increase_model_pathattributeself.xcrg_decrease_model_pathattribute6.
code/ARAX/Documentation/DSL_Documentation.mdWhat was removed:
infer(action=chemical_gene_regulation_graph_expansion)### infer(action=chemical_gene_regulation_graph_expansion)section with all parameter documentation7.
code/UI/interactive/araxi.jsWhat was removed:
"infer(action=chemical_gene_regulation_graph_expansion)"JSON block with all parameter definitions8.
.gitignoreWhat was removed:
code/ARAX/ARAXQuery/Infer/data/xCRG_data/*.ptcode/ARAX/ARAXQuery/Infer/data/xCRG_data/*.npz