Skip to content

chore: upgrade packaging from 23.0 to 26.3 - #5403

Merged
causten merged 1 commit into
ROCm:developfrom
VishalX:docker/fix-packaging-version-wrt-pipx
Oct 19, 2026
Merged

causten merged 1 commit into
ROCm:developfrom
VishalX:docker/fix-packaging-version-wrt-pipx

Conversation

@VishalX

@VishalX VishalX commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Upgrades the packaging module to version 26.3 to support the latest pipx version (updated recently), which requires features not available in packaging 23.0.

Error traceback:

 > [24/32] RUN pipx install --global yapf==0.28.0:                                                                                                                                                                        
0.226 Traceback (most recent call last):                                                                                                                                                                                  
0.226   File "/usr/local/bin/pipx", line 5, in <module>                                                                                                                                                                   
0.226     from pipx.__main__ import cli
0.226   File "/usr/local/lib/python3.12/dist-packages/pipx/__main__.py", line 35, in <module>
0.227     from pipx.main import cli
0.227   File "/usr/local/lib/python3.12/dist-packages/pipx/main.py", line 78, in <module>
0.227     from pipx.package_specifier import valid_pypi_name
0.227   File "/usr/local/lib/python3.12/dist-packages/pipx/package_specifier.py", line 22, in <module>
0.227     from packaging.utils import InvalidName, canonicalize_name
0.227 ImportError: cannot import name 'InvalidName' from 'packaging.utils' (/usr/local/lib/python3.12/dist-packages/packaging/utils.py)

This fixes docker build failures (shown above) when using the updated pipx.


Follow the LLVM AI Tool Use Policy for contributions using AI.

Upgrades the packaging module to version 26.3 to support the latest pipx
version, which requires features not available in packaging 23.0. This fixes
build failures when using the updated pipx.
Copilot AI balanced review requested due to automatic review settings October 16, 2026 15:37
@VishalX
VishalX requested a review from causten as a code owner October 16, 2026 15:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Dependency resolution and a fresh Docker build remain unverified, so pipx compatibility needs confirmation.

0 open findings

What changed in this PR

Updates MIGraphX’s Python dependency pin to address Docker build failures with newer pipx versions.

Changes:

  • Bumps packaging from 23.0 to 26.3.
File Description
tools/​requirements-py.txt Updates the pinned packaging version.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@causten
causten merged commit 40de90e into ROCm:develop Oct 19, 2026
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants