ci: Nighly tests against latest polars versions - #62
ci: Nighly tests against latest polars versions#62Marius Merkle (MariusMerkleQC) wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pixi-update/pixi.toml #62 +/- ##
=======================================================
Coverage 100.00% 100.00%
=======================================================
Files 13 13
Lines 1138 1138
=======================================================
Hits 1138 1138 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| ) | ||
| comparison = compare_frames(left, right, primary_key=primary_key) | ||
| assert_frame_equal(expected, comparison.joined()) | ||
| assert_frame_equal(expected, comparison.joined(), check_row_order=False) |
There was a problem hiding this comment.
Surfaced when running pixi run -e nightly test-coverage with 2.0.0rc1. I assume it's the streaming engine that doesn't preserve row order.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are CI/test-focused and low-risk, and the only noted improvement is an operational log clarity enhancement rather than a functional blocker.
Pull request overview
Adds a scheduled GitHub Actions workflow to run Diffly’s test suite nightly against the latest Polars prereleases (to catch upstream compatibility issues early), along with minor test adjustments to tolerate nondeterministic row ordering.
Changes:
- Add a
nightlypixi environment + task to install prerelease Polars via pip. - Add a new
NightlyGitHub Actions workflow that runs tests on a schedule (Ubuntu + Windows) using thenightlyenvironment. - Update join-related tests to compare frames without requiring stable row ordering.
File summaries
| File | Description |
|---|---|
| tests/test_joined.py | Make joined-frame assertions row-order-insensitive. |
| tests/test_joined_equal_unequal.py | Make joined-equal assertions row-order-insensitive. |
| pixi.toml | Add nightly feature task + nightly environment. |
| pixi.lock | Lockfile update to include the new nightly environment. |
| .github/workflows/nightly.yml | New scheduled workflow to run tests with Polars prereleases. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Motivation
I wanted to run our tests against the polars pre-release version
v2.0.0.dataframelyruns this every night against the latest polars versions which is a nice idea in my opinion.Changes