chore: Add pull_request trigger to CI workflow - #61
chore: Add pull_request trigger to CI workflow#61Marius Merkle (MariusMerkleQC) wants to merge 1 commit into
pull_request trigger to CI workflow#61Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1138 1138
=========================================
Hits 1138 1138 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
The trigger change introduces an unmentioned behavior change (no CI on non-main pushes) and may break/alter CI runs for fork PRs due to missing secrets used by Codecov steps.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the GitHub Actions CI workflow so it runs for pull requests (including PRs opened from forks), addressing the gap where CI previously only ran on push events.
Changes:
- Switches the workflow trigger from
on: [push]to explicitpush+pull_requesttriggers. - Limits
pushruns to themainbranch (new behavior vs. prior “all pushes”).
File summaries
| File | Description |
|---|---|
| .github/workflows/ci.yml | Adds pull_request trigger and changes push trigger scope to main. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Marius Merkle (MariusMerkleQC)
changed the title
pull_request trigger to CI workflow
Motivation
The CI workflow doesn't run on PRs from forks such as in #58. I'd like to change the trigger so that it runs on PRs and pushed to
main. It will no longer run on pushed to non-main branches without PRs.Changes