fix(lifecycle): restore backtest readback metadata - #635
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
BacktestResult.to_dict()persistscost_inputsandvalidation_identity, butPerformanceStore._backtest_from_dict()discarded both. This made the new exact run readback unable to verify the cost assumptions saved by the SOXL/TQQQ synthetic replay.Restore those fields on readback. Keep missing legacy fields at the existing empty defaults and reject explicitly malformed metadata. Save paths and latest baseline selection are unchanged. A stored identity remains metadata and does not authorize promotion; the existing promotion gates still require complete orchestrator, folds, OOS and source evidence.
Evidence
uv run --frozen python -m unittest tests.test_lifecycle_performance_store -q: 18 tests OK.uv run --frozen --with pytest python -m pytest tests/test_lifecycle_performance_store.py tests/test_strategy_performance_export.py -q: 27 passed.uv run --frozen --with pytest python -m pytest tests/test_backtest_orchestrator.py -q: 27 passed, 11 subtests passed.git diff --check: passed.No real cloud store, market data, accounts, orders, deployment or production configuration were accessed. The repository's pre-existing lock mismatch remains unchanged, so the local QPK checks used
--frozen.