Repository navigation
Conversation
Mirror the "simple" branch of TiltedIrradiation. Before, cells without data (e.g. north of 65 N in SARAH cutouts) returned NaN and made aggregated time series NaN.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
With
trigon_model="other",TiltedIrradiationreturned NaN in cells without irradiation data, e.g. north of 65° N in SARAH cutouts. Any aggregated time series (layout,matrix,shapes) that includes such a cell became NaN for all time steps.The
"simple"branch already fills missing direct, diffuse and ground irradiation with zero. This PR does the same for the other branch (one line), so both models treat missing data the same way.Note: zero-filling means cells without data contribute no generation rather than marking the result as unknown. This is the existing behaviour of the default
"simple"model.Checklist
doc.environment.yaml,environment_docs.yamlandsetup.py(if applicable).doc/release_notes.rstof the upcoming release is included.