Conversation
Treat org.freedesktop.secrets as the runtime contract instead of requiring GNOME Keyring. Avoid validation-time secret access, resolve a missing default alias conservatively, and reuse one serialized D-Bus connection so provider authorization can persist across operations. Keep GNOME Keyring as a packaging suggestion and cover validation, collection selection, and connection lifetime with focused tests. Development disclosure: I developed this patch with material assistance from OpenAI Codex under my direction, then reviewed, tested, and signed the final change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The package requires GNOME Keyring even though its runtime interface is the Freedesktop Secret Service API. That prevents desktop-selected providers from being treated as first-class implementations.
The current availability check also performs a real keyring operation. This can require a usable
defaultcollection, create one as a side effect, or prompt before the client actually needs a secret. Python Keyring opens a fresh Secret Service connection for each operation, so providers that authorize clients by D-Bus identity may prompt repeatedly.Change
defaultalias; if it is missing or stale, use the sole advertised collection, create a default only when no collection exists, and reject ambiguous multi-collection fallback.GNOME Keyring, KeePassXC, KWallet, and other conforming Secret Service implementations use the same code path. No provider-specific logic or secret-storage schema change is introduced.
Verification
ruff check, Python bytecode compilation, andgit diff --checkpass.org.freedesktop.secrets, including cold start, login, sign-out/sign-in, reconnect, and one authorization prompt per client start.Closes #3.
Development disclosure: I developed this patch with material assistance from OpenAI Codex under my direction, then reviewed, tested, and signed the final change.