Skip to content

Take the formal specs off main - #158

Merged
zaoxing merged 1 commit into
mainfrom
revert/formal-specs
Sep 28, 2026
Merged

zaoxing merged 1 commit into
mainfrom
revert/formal-specs

Conversation

@zaoxing

@zaoxing zaoxing commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

Reverts #157 (71e6663), which added specs/: TLA+ models of the publisher lease and version allocator, a Z3 check of the clock-skew arithmetic, a CBMC harness for the ring's span arithmetic, and specs/check.sh. They are not meant to live on main.

  • Removes only specs/, 91 files and 4,984 lines. Nothing outside specs/ refers to them.
  • The resulting tree is byte-identical to 99ee4ae, main before Add TLA+, Z3 and CBMC specs for the lease, allocator and ring span arithmetic #157, which passed CI.
  • The specs are kept off main on the branch specs/formal-models-archive, at 71e6663.
  • The findings the models produced stay on the fix list for the native code:
    • lease request time is unbounded;
    • the index_bounded() renewal clock is restarted without a renewal.

Reverts 71e6663 (#157), which added specs/: TLA+ models of the publisher
lease and version allocator, a Z3 check of the clock-skew arithmetic, a
CBMC harness for the ring's span arithmetic, and specs/check.sh. They are
not meant to live on main. The work is kept on the branch
specs/formal-models-archive (at 71e6663); the findings it produced are
tracked as fixes in the native code.
Copilot AI lite review requested due to automatic review settings September 28, 2026 16:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@zaoxing
zaoxing merged commit 3f59db5 into main Sep 28, 2026
3 checks passed
@zaoxing
zaoxing deleted the revert/formal-specs branch September 28, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants