Skip to content

chore: adopt Planner CandidatePostASAPDAGs API #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzylol wants to merge 1 commit into
base: fix/placement-pricing-evidence
Choose a base branch
from
Open

chore: adopt Planner CandidatePostASAPDAGs API #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ version = "0.1.0"
[workspace.dependencies]
# Keep Planner frontends, selection, and IR on the same immutable revision.
# Alias upstream asap-types because this workspace also defines asap_types.
planner-types = { package = "asap-types", git = "https://github.com/ProjectASAP/ASAPPlanner", rev = "a049a3b6c17cee4c51c79e478799b32280a7d71d" }
asap-aware-mapping = { git = "https://github.com/ProjectASAP/ASAPPlanner", rev = "a049a3b6c17cee4c51c79e478799b32280a7d71d" }
asap-frontend-promql = { git = "https://github.com/ProjectASAP/ASAPPlanner", rev = "a049a3b6c17cee4c51c79e478799b32280a7d71d" }
asap-frontend-sql = { git = "https://github.com/ProjectASAP/ASAPPlanner", rev = "a049a3b6c17cee4c51c79e478799b32280a7d71d" }
planner-types = { package = "asap-types", git = "https://github.com/ProjectASAP/ASAPPlanner", rev = "ea12b31680be777b1866d3ea5fc82fd4a9a3e57e" }
asap-aware-mapping = { git = "https://github.com/ProjectASAP/ASAPPlanner", rev = "ea12b31680be777b1866d3ea5fc82fd4a9a3e57e" }
asap-frontend-promql = { git = "https://github.com/ProjectASAP/ASAPPlanner", rev = "ea12b31680be777b1866d3ea5fc82fd4a9a3e57e" }
asap-frontend-sql = { git = "https://github.com/ProjectASAP/ASAPPlanner", rev = "ea12b31680be777b1866d3ea5fc82fd4a9a3e57e" }

# Shared external deps (used by 2+ crates)
serde = { version = "1.0", features = ["derive"] }
Expand All @@ -39,7 +39,7 @@ arc-swap = "1.7"
reqwest = { version = "0.12", default-features = false, features = ["json", "rustls-tls"] }

# Internal crates
asap-physical-operators = { git = "https://github.com/ProjectASAP/ASAPPlanner", rev = "a049a3b6c17cee4c51c79e478799b32280a7d71d" }
asap-physical-operators = { git = "https://github.com/ProjectASAP/ASAPPlanner", rev = "ea12b31680be777b1866d3ea5fc82fd4a9a3e57e" }
asap_sketch_codec = { path = "crates/asap_sketch_codec" }
asap_summary_state = { path = "crates/asap_summary_state" }
asap_types = { path = "crates/asap_types" }
Expand Down
6 changes: 3 additions & 3 deletions control_plane/src/physical/compiler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,7 +1043,7 @@ impl BackendLocalPlanningInput {
exact_costs_by_id.insert(format!("compat-query-{index}"), rows.clone());
}
}
// PromQL rows carry their complete identity before PlanSpace chooses
// PromQL rows carry their complete identity before CandidatePostASAPDAGs chooses
// shared states, so arithmetic never needs a second logical selection.
let logical_roots = canonical_roots
.iter()
Expand Down Expand Up @@ -1089,7 +1089,7 @@ impl BackendLocalPlanningInput {
}
let mut planner_candidate_forests = Vec::new();
// Native physical realizations need the complete series identity in
// their rows. Planner's PlanSpace proposes them for the identity-typed
// their rows. Planner's CandidatePostASAPDAGs proposes them for the identity-typed
// root; each is a logical alternative whose readout-built states are
// placed by lifecycle, then substituted into the preferred workload.
for (index, root) in canonical_roots.iter().enumerate() {
Expand Down Expand Up @@ -5394,7 +5394,7 @@ pub(crate) mod tests {
snapshot
}

// Per-series arithmetic compiles on the first selection, without retrying PlanSpace.
// Per-series arithmetic compiles on the first selection, without retrying CandidatePostASAPDAGs.
#[test]
fn logical_candidates_have_series_identity_before_selection() {
let (request, _) = exact_workload_snapshot(&["avg_over_time(data[5m])"])
Expand Down
2 changes: 1 addition & 1 deletion control_plane/src/physical/workload_cost.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ mod tests {
use super::super::compiler::BackendLocalPlanningInput;
use super::*;

/// PlanSpace decides the computation: every quantile family it can
/// CandidatePostASAPDAGs decides the computation: every quantile family it can
/// realize is ranked in the selection trace, and one is committed.
#[test]
fn planner_ranks_quantile_families_before_committing_one() {
Expand Down
2 changes: 1 addition & 1 deletion docs/examples/workload-cost-evidence.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ measurements.

The default inventory compares the Planner-selected workload with its
whole-workload exact fallback, maintained-population variants, and one
substitution per native physical realization that Planner's PlanSpace proposes
substitution per native physical realization that Planner's CandidatePostASAPDAGs proposes
for a query (for example a heap over per-series Rate readouts). Planner's
global selection, not a quote per alternative, decides every other summary
choice such as the sketch family. Within a candidate, whether each summary state
Expand Down
Loading