Conversation
zzylol
marked this pull request as draft
September 30, 2026 15:03
zzylol
force-pushed
the
fix/placement-pricing-lag
branch
from
September 30, 2026 15:04
8c8aeda to
e899d10
Compare
zzylol
force-pushed
the
fix/placement-pricing-evidence
branch
from
September 30, 2026 15:04
797dbe5 to
c976121
Compare
…ntly Price derived maintenance lookbacks and native retained candidates from installed window layouts. Use optional fresh per-metric sample-rate evidence for both retained updates and raw folds, and charge generated shared Sum panes once across logical lookbacks while preserving each read cost. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
fix/placement-pricing-lag
branch
from
September 30, 2026 15:18
e899d10 to
ec8786e
Compare
zzylol
force-pushed
the
fix/placement-pricing-evidence
branch
from
September 30, 2026 15:18
c976121 to
e3de66f
Compare
zzylol
marked this pull request as ready for review
September 30, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #808.
Why
Placement prices could disagree with the installed plan: downstream maintenance needed more panes than priced, and each raw selector inherited the entire workload's sample rate. Distinct logical lookbacks also charged a shared physical Sum producer twice.
What
implementation.source_ingestion_ratesevidence by metric, applying fresh rates consistently to retained updates and raw folds. Missing or stale evidence keeps the conservative workload rate.Before this PR
A 1m and 10m read sharing one Sum producer charged 68 panes although only 61 were installed. A longer derived consumer could price two source panes when maintenance needed eleven.
After this PR
Those cases price 61 and eleven panes respectively. Explicit source rates replace workload totals for both placement alternatives without assuming label-filter selectivity.
Validation
a049a3b: formatting, workspace clippy, workspace library tests, all control-plane tests, and all 30 compatibility process tests pass (122.91s). Native candidate retention pricing lives upstream in feat: adopt versioned Planner kernels and typed physical selection #810.🤖 Generated with Claude Code