refactor: delete unused precompute coordinator and series buffer - #790
Merged
Merged
Conversation
`multisource_coordinator`, `coordination_checkpoint` and `series_buffer` have no callers outside themselves and `mod.rs`; production precompute does not construct them. Remove them (1.8k lines) and their design-doc sections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Step toward DAG-only precompute execution: remove precompute modules that no
production path uses, so the remaining engine code reflects what actually runs.
What
Delete three modules (1.8k lines) that are referenced only by each other and
by
precompute_engine/mod.rs:multisource_coordinator.rs(1104 lines)coordination_checkpoint.rs(548 lines)series_buffer.rs(163 lines)precompute_engine_design_doc.mddrops theSeriesBuffersection (§3.5,later sections renumbered), its
SeriesStatefield and the module-table andunit-test mentions.
Before this PR
After this PR
No references remain. No behavior change.
Not in scope
pass_raw_samples): default-off but a documented benchmarkmode, so removing it is a separate decision.
hot_reload_config.rsand test-only legacyaccumulator paths: they overlap Bind Planner physical candidates without Backend operator lowering #788 and follow it.
Validation
cargo clippy --workspace --all-targets --locked -- -D warningsandcargo fmt --checkpass;cargo test --workspace --locked --lib: 1449 passed.🤖 Generated with Claude Code