Conversation
This reverts commit daa5281.
zzylol
force-pushed
the
fix/708-mask-routing
branch
from
September 21, 2026 17:31
d8995dc to
16f75d2
Compare
CompileAndPublishPhysicalPlanRequest gained a required `dataset_identity` field in this branch, but two api_tests fixtures build their request body as JSON by hand and were never updated, so both failed deserialization with `missing field dataset_identity` before reaching the handler. Take the value from the planning snapshot's own `environment.dataset_identity` rather than inventing one, so the fixture keeps describing the same dataset the rest of the snapshot describes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #708. Stacked on #749; review this PR after the backend plan/SDS refactor.
Physical alternatives are sets of materialization keys, so neither the 64-candidate rejection nor the 63-set enumeration cutoff reflects a representation limit. This change removes both limits and the redundant deduplication for distinct large-inventory choices.
With 100 optional keys, candidate generation now produces 202 materialization choices plus native execution, and selection considers every supplied alternative. Search remains exhaustive through four keys; larger inventories consider all/none and every singleton/complement pair (2 + 2N). That larger search is intentionally non-exhaustive and may increase compilation and pricing work.
This branch includes the updated #749 foundation. Its review diff contains only
control_plane/src/physical/workload_cost.rsandcontrol_plane/src/physical/workload_cost/materialization_candidates.rs.Verification on the stacked branch:
cargo test -p control_plane --lockedpassed (426 library tests and integration targets);cargo fmt --all --checkandgit diff --checkpassed.