Skip to content

DDSketch drops zero values; bump asap_sketchlib past #141 #773

Description

@GordonYuanyc

data_plane pins asap_sketchlib 026cd18c, whose DDSketch ignores values ≤ 0. Two effects:

  • Warm quantiles are computed over the positive values only. For a series with 80% zeros, p50 comes back 5.87; the exact value is 0.
  • If any series is all zeros in the window, readout fails with DDS interpolated quantile is unavailable and the whole query is forwarded.

asap_sketchlib aa540b6 (#141) fixes this. It is not in a tag yet, but Cargo.lock already uses a later revision (a66fad6c) for asap-aware-mapping.

Ask: bump data_plane / asap-precompute-rs to ≥ aa540b6.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions